intfiction.org

The Interactive Fiction Community Forum
It is currently Sat May 25, 2013 6:35 am

All times are UTC - 6 hours [ DST ]




Post new topic Reply to topic  [ 152 posts ]  Go to page Previous  1 ... 4, 5, 6, 7, 8, 9, 10 ... 16  Next
Author Message
PostPosted: Tue Aug 16, 2011 7:51 am 
Offline
User avatar

Joined: Sat Dec 22, 2007 6:00 pm
Posts: 355
Location: Western Australia
0.9.2 is looking really nice! Some further observations, for when you get another two free weeks of coding time:

Although the import process now recognises TADS 3 games, it's still having trouble extracting metadata from many of them. For instance, David Fletcher's SpeedIF Light of My Stomach failed to import. It didn't even manage to extract the IFID, instead generating a default "TADS3-[etc]" IFID. Actually, TADS 2 games also seem to suffer from this problem. Grotesque failed to extract the IFID from Slap That Fish as well, instead generating a default, incorrect IFID for it. And even in the cases where a game has no IFID embedded in it, the IFID generation doesn't seem to be producing the correct IFID - at least, they never match the ones listed on IFDB.

The alphabetisation of the Author panel isn't very sophisticated. It puts all the names starting with uppercase letters first, then the lowercased names, and then poor Øyvind Thorsby all alone at the bottom.

When the import progress dialog resizes itself to fit an extra long file name, the dialog ends up longer than progress bar (see attached screenshot). It's only temporary; when the import moves on to a different game, it resizes the progress bar and moves the cancel button to fit the window. But it looks strange while in the mean time.


Attachments:
File comment: import dialog behaving strangely
Screenshot.png
Screenshot.png [ 29.27 KiB | Viewed 147 times ]

_________________
Emily Boegheim
Top
 Profile Send private message  
 
PostPosted: Tue Aug 16, 2011 7:56 am 
Offline

Joined: Sun Aug 14, 2011 6:21 am
Posts: 127
RealNC wrote:
Ah, OK. That's easy to fix on my part too. I can simply bump the version req of the Python dependency in the Gentoo ebuild script which will make sure the user installing it will have Python 2.7 installed. (2.7 is in Gentoo for a long time now, it's just that I didn't allow the update yet on my system and was actively blocking it; the vast majority of other Gentoo users already have the updated 2.7 Python.)


Ok! Thanks for packaging it for Gentoo!! When it's online, I can put a link to it in the original post of this thread.

_________________
Grotesque: an interactive fiction library manager for Linux
PyIFBabel: a Treaty of Babel library for Python


Top
 Profile Send private message  
 
PostPosted: Tue Aug 16, 2011 8:07 am 
Offline
User avatar

Joined: Tue Apr 20, 2010 2:48 pm
Posts: 688
Btw, I noticed you saying that you're waiting for FTP access to the SF web space. FTP doesn't work anymore with SF. You need to login through SFTP (meaning through SSH). The URL is of the form:

sftp://username,projectname@web.sourceforge.net

And of course you need an SFTP-capable client.


Top
 Profile Send private message  
 
PostPosted: Tue Aug 16, 2011 8:14 am 
Offline

Joined: Sun Aug 14, 2011 6:21 am
Posts: 127
Emerald wrote:
0.9.2 is looking really nice! Some further observations, for when you get another two free weeks of coding time:

Although the import process now recognises TADS 3 games, it's still having trouble extracting metadata from many of them. For instance, David Fletcher's SpeedIF Light of My Stomach failed to import. It didn't even manage to extract the IFID, instead generating a default "TADS3-[etc]" IFID. Actually, TADS 2 games also seem to suffer from this problem. Grotesque failed to extract the IFID from Slap That Fish as well, instead generating a default, incorrect IFID for it. And even in the cases where a game has no IFID embedded in it, the IFID generation doesn't seem to be producing the correct IFID - at least, they never match the ones listed on IFDB.

The alphabetisation of the Author panel isn't very sophisticated. It puts all the names starting with uppercase letters first, then the lowercased names, and then poor Øyvind Thorsby all alone at the bottom.

When the import progress dialog resizes itself to fit an extra long file name, the dialog ends up longer than progress bar (see attached screenshot). It's only temporary; when the import moves on to a different game, it resizes the progress bar and moves the cancel button to fit the window. But it looks strange while in the mean time.


Thanks for the feedback! Tackling the metadata extraction is my next big task. I really haven't touched that code at all since inheriting the project. From what I recall in having glanced through the (undocumented) code, I think it is, indeed, generating IFIDs for TADS games rather than extracting them. I'll profess *complete* ignorance on this subject. I have a lot of learning to do before I can get this part working nicely. Until then, I apologize that a lot of manual entry will be needed, but at least it's not outright failing with a crash/hang anymore. :P

Alphabetisation: Thus far I have used the built-in GTK sorting and I've also noticed the problem. I'm looking into Python implementations of the Unicode Collation Algorithm, which would solve this. As far as the capitalization, I had initially considered automatically capitalizing author names but in the end I made a conscious decision to leave that to the user to do. Nonetheless, capitalization should not affect sorting.

Thanks for letting me know about the progress dialog resizing itself. That's an easy fix.

_________________
Grotesque: an interactive fiction library manager for Linux
PyIFBabel: a Treaty of Babel library for Python


Top
 Profile Send private message  
 
PostPosted: Tue Aug 16, 2011 8:15 am 
Offline

Joined: Sun Aug 14, 2011 6:21 am
Posts: 127
RealNC wrote:
Btw, I noticed you saying that you're waiting for FTP access to the SF web space. FTP doesn't work anymore with SF. You need to login through SFTP (meaning through SSH). The URL is of the form:

sftp://username,projectname@web.sourceforge.net

And of course you need an SFTP-capable client.


I've logged in just fine, the problem is that I apparently don't have permisisons to view the files yet, because they're not in my projectweb space.

_________________
Grotesque: an interactive fiction library manager for Linux
PyIFBabel: a Treaty of Babel library for Python


Top
 Profile Send private message  
 
PostPosted: Tue Aug 16, 2011 8:20 am 
Offline
User avatar

Joined: Tue Apr 20, 2010 2:48 pm
Posts: 688
jakobcreutzfeldt wrote:
I've logged in just fine, the problem is that I apparently don't have permisisons to view the files yet, because they're not in my projectweb space.

Just in case, the web space was moved to:

/home/project-web/grotesque/htdocs/


Top
 Profile Send private message  
 
PostPosted: Tue Aug 16, 2011 9:02 am 
Offline
User avatar

Joined: Tue Apr 20, 2010 2:48 pm
Posts: 688
OK, I updated my installation to Python 2.7 and it now works OK. Will finish up the Gentoo ebuild soon and make it available on the interactive-fiction overlay.

One request: can you add QTads (executable "qtads") as a possible choice for TADS (2 and 3) games and Hugor (executable "hugor") for Hugo games? (Hugo game extension is ".hex".) Not just a shameless plug, but these two support the full feature set of Tads and Hugo games (formatting, graphics, sound) and are not just text-only :P

Also, I noticed that the application uses ~/.grotesque as its default configuration file dir. It should preferably be using the ~/.config/ directory, or the directory contained in the $XDG_CONFIG_HOME env var. The standard can be found here:

http://standards.freedesktop.org/basedi ... atest.html

Applications following accepted standards make life easier for all Linux users :-)


Top
 Profile Send private message  
 
PostPosted: Tue Aug 16, 2011 9:14 am 
Offline

Joined: Sun Aug 14, 2011 6:21 am
Posts: 127
RealNC wrote:
jakobcreutzfeldt wrote:
I've logged in just fine, the problem is that I apparently don't have permisisons to view the files yet, because they're not in my projectweb space.

Just in case, the web space was moved to:

/home/project-web/grotesque/htdocs/


Yep, that's where I'm checking. My project-web folder is empty. I contacted the original author of Grotesque but I haven't heard anything back. I'll probably contact Sourceforge myself soon.

_________________
Grotesque: an interactive fiction library manager for Linux
PyIFBabel: a Treaty of Babel library for Python


Top
 Profile Send private message  
 
PostPosted: Tue Aug 16, 2011 9:18 am 
Offline

Joined: Sun Aug 14, 2011 6:21 am
Posts: 127
RealNC wrote:
OK, I updated my installation to Python 2.7 and it now works OK. Will finish up the Gentoo ebuild soon and make it available on the interactive-fiction overlay.


Sounds good! My Arch Linux links are getting lonely on the front page.

Quote:
One request: can you add QTads (executable "qtads") as a possible choice for TADS (2 and 3) games and Hugor (executable "hugor") for Hugo games? (Hugo game extension is ".hex".) Not just a shameless plug, but these two support the full feature set of Tads and Hugo games (formatting, graphics, sound) and are not just text-only :P


Sure, that's no problem to add!

Quote:
Also, I noticed that the application uses ~/.grotesque as its default configuration file dir. It should preferably be using the ~/.config/ directory, or the directory contained in the $XDG_CONFIG_HOME env var. The standard can be found here:

http://standards.freedesktop.org/basedi ... atest.html

Applications following accepted standards make life easier for all Linux users :-)


That is an excellent suggestion. I'll implement that for the next version.
In the config folder there's a subfolder for storing the cover art. Do you think that should go in ~/.local/share?
And then I need to figure out what's best for Windows....

_________________
Grotesque: an interactive fiction library manager for Linux
PyIFBabel: a Treaty of Babel library for Python


Top
 Profile Send private message  
 
PostPosted: Tue Aug 16, 2011 9:36 am 
Offline
User avatar

Joined: Tue Apr 20, 2010 2:48 pm
Posts: 688
jakobcreutzfeldt wrote:
In the config folder there's a subfolder for storing the cover art. Do you think that should go in ~/.local/share?

Yes, it's user data so it goes to $XDG_DATA_HOME/grotesque/, and if that var is either empty or not defined, then to the hard-coded fallback "~/.local/share/grotesque/".

Quote:
And then I need to figure out what's best for Windows....

Windows has env vars too for this:

http://stackoverflow.com/questions/6267 ... ing-python


Top
 Profile Send private message  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 152 posts ]  Go to page Previous  1 ... 4, 5, 6, 7, 8, 9, 10 ... 16  Next

All times are UTC - 6 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group