intfiction.org

The Interactive Fiction Community Forum
It is currently Sat Feb 23, 2019 4:52 am

All times are UTC - 6 hours [ DST ]




Post new topic Reply to topic  [ 10 posts ] 
Author Message
 Post subject: Enhanced GlkTerm
PostPosted: Mon Jan 14, 2019 5:45 pm 
Offline

Joined: Sat Oct 04, 2008 9:21 pm
Posts: 257
I made Enhanced GlkTerm with many enhancements. The enhancements are explained in the file called "enhanced-readme".

Download: http://zzo38computer.org/misc2/glkterm.zip

Here is a list of some of the new features:
  • Can use a .glktermrc file to store user preferences
  • Can display "More" when paging
  • Support paging when glk_exit() is called
  • Colours are supported
  • Can set read-only mode; most files opened by Glk fileref functions are read-only
  • You can also prohibit all file access entirely
  • Filename mapping
  • User-definable styles
  • Can disable mangling of filenames entered by glk_fileref_create_by_prompt()
  • Can set clock skew for the Glk date/time functions
  • VT100 line graphics for window borders
  • New command-line option -- which makes it to treat further arguments as plain arguments (so filenames can have - at first)

_________________
.


Last edited by zzo38 on Tue Jan 15, 2019 1:21 am, edited 1 time in total.

Top
 Profile Send private message  
Reply with quote  
 Post subject: Re: Enhanced GlkTerm
PostPosted: Tue Jan 15, 2019 12:17 am 
Offline
User avatar

Joined: Wed Oct 14, 2009 4:02 am
Posts: 2600
Please submit these as pull requests at https://github.com/erkyrath/glkterm

Obviously you've put in a lot of effort, so please ensure the changes get put in for consideration for merging into the official code.


Top
 Profile Send private message  
Reply with quote  
 Post subject: Re: Enhanced GlkTerm
PostPosted: Tue Jan 15, 2019 1:19 am 
Offline

Joined: Sat Oct 04, 2008 9:21 pm
Posts: 257
I don't use git. However, anyone else is free to do if you like to do. If you do include some or all of my changes (possibly further modified, if you wish, for any reason), you are free to convert them to MIT license, or even to release to public domain if you prefer; you have my permission for these things.

However, I have looked at the most recent commits in that repository. One recent change is the use of mkstemp() instead of tmpnam(); I have already did that, before I saw this repository (my code is also a bit different; it checks for errors, and supports a user preference to change the template for the filename). The other is a minor change to gli_date_to_tm(), which I have just fixed now (and is now available for downloading).

_________________
.


Top
 Profile Send private message  
Reply with quote  
 Post subject: Re: Enhanced GlkTerm
PostPosted: Sun Feb 10, 2019 10:59 am 
Offline

Joined: Wed Nov 12, 2014 5:20 pm
Posts: 222
FYI, i just upped zzo38's Enhanced GlkTerm source code to Github here, mostly to make the changes more readable.


Top
 Profile Send private message  
Reply with quote  
 Post subject: Re: Enhanced GlkTerm
PostPosted: Sat Feb 16, 2019 12:45 pm 
Offline
User avatar

Joined: Mon Dec 12, 2011 7:03 pm
Posts: 577
Location: Washington
I'll have some good coding time soon and I'd like to get all this ready to merge with Zarf's standard. @zzo38, would you please pm or email me with the email address you want inserted into the glkterm git repo so that everyone will know who made the changes?

_________________
David Griffith


Top
 Profile Send private message  
Reply with quote  
 Post subject: Re: Enhanced GlkTerm
PostPosted: Mon Feb 18, 2019 4:00 pm 
Offline

Joined: Sat Oct 04, 2008 9:21 pm
Posts: 257
DavidG wrote:
I'll have some good coding time soon and I'd like to get all this ready to merge with Zarf's standard. @zzo38, would you please pm or email me with the email address you want inserted into the glkterm git repo so that everyone will know who made the changes?
I have sent it to you by private message on this forums. However, I have fixed a few bugs having to do with the implementation of gestalt selector 0x14FE, so if you want to merge the coding having to do with that gestalt selector then you should redownload it.

_________________
.


Top
 Profile Send private message  
Reply with quote  
 Post subject: Re: Enhanced GlkTerm
PostPosted: Wed Feb 20, 2019 7:06 am 
Offline
User avatar

Joined: Mon Dec 12, 2011 7:03 pm
Posts: 577
Location: Washington
zzo38 wrote:
DavidG wrote:
I'll have some good coding time soon and I'd like to get all this ready to merge with Zarf's standard. @zzo38, would you please pm or email me with the email address you want inserted into the glkterm git repo so that everyone will know who made the changes?
I have sent it to you by private message on this forums. However, I have fixed a few bugs having to do with the implementation of gestalt selector 0x14FE, so if you want to merge the coding having to do with that gestalt selector then you should redownload it.


Thanks. I'm going over your changes and testing them. I found one oddity, the following lines were missing from the "readme" file:

Code:
1.0.5###:
Fixed a struct initialization bug in gli_date_to_tm(). (I think this
caused no problems in practice.)
Replaced tmpnam() with mkstemp() (thanks David Griffith).


Were did you get the code upon which you made your changes?

_________________
David Griffith


Top
 Profile Send private message  
Reply with quote  
 Post subject: Re: Enhanced GlkTerm
PostPosted: Fri Feb 22, 2019 6:16 pm 
Offline

Joined: Sat Oct 04, 2008 9:21 pm
Posts: 257
DavidG wrote:
zzo38 wrote:
DavidG wrote:
I'll have some good coding time soon and I'd like to get all this ready to merge with Zarf's standard. @zzo38, would you please pm or email me with the email address you want inserted into the glkterm git repo so that everyone will know who made the changes?
I have sent it to you by private message on this forums. However, I have fixed a few bugs having to do with the implementation of gestalt selector 0x14FE, so if you want to merge the coding having to do with that gestalt selector then you should redownload it.


Thanks. I'm going over your changes and testing them. I found one oddity, the following lines were missing from the "readme" file:

Code:
1.0.5###:
Fixed a struct initialization bug in gli_date_to_tm(). (I think this
caused no problems in practice.)
Replaced tmpnam() with mkstemp() (thanks David Griffith).


Were did you get the code upon which you made your changes?
It was the previous version (from zarf's webpage) that I got the code from to make my changes (although I independently had the same idea about mkstemp(), and after seeing the GitHub I also fixed the other bug).

_________________
.


Top
 Profile Send private message  
Reply with quote  
 Post subject: Re: Enhanced GlkTerm
PostPosted: Fri Feb 22, 2019 10:30 pm 
Offline
User avatar

Joined: Mon Dec 12, 2011 7:03 pm
Posts: 577
Location: Washington
zzo38 wrote:
DavidG wrote:
Thanks. I'm going over your changes and testing them. I found one oddity, the following lines were missing from the "readme" file:

Code:
1.0.5###:
Fixed a struct initialization bug in gli_date_to_tm(). (I think this
caused no problems in practice.)
Replaced tmpnam() with mkstemp() (thanks David Griffith)


Were did you get the code upon which you made your changes?
It was the previous version (from zarf's webpage) that I got the code from to make my changes (although I independently had the same idea about mkstemp(), and after seeing the GitHub I also fixed the other bug).


It would be best if you could fork Zarf's latest code at Github, apply your changes, and submit a pull request.

_________________
David Griffith


Top
 Profile Send private message  
Reply with quote  
 Post subject: Re: Enhanced GlkTerm
PostPosted: Fri Feb 22, 2019 11:17 pm 
Offline

Joined: Sat Oct 04, 2008 9:21 pm
Posts: 257
DavidG wrote:
zzo38 wrote:
DavidG wrote:
Thanks. I'm going over your changes and testing them. I found one oddity, the following lines were missing from the "readme" file:

Code:
1.0.5###:
Fixed a struct initialization bug in gli_date_to_tm(). (I think this
caused no problems in practice.)
Replaced tmpnam() with mkstemp() (thanks David Griffith)


Were did you get the code upon which you made your changes?
It was the previous version (from zarf's webpage) that I got the code from to make my changes (although I independently had the same idea about mkstemp(), and after seeing the GitHub I also fixed the other bug).


It would be best if you could fork Zarf's latest code at Github, apply your changes, and submit a pull request.
As explained before, I do not use Git and do not really intend to get a GitHub account. However, I have now made the only correction I was missing (C++ style comments giving compiler warnings in glk.h, now changed to C style comments).

_________________
.


Top
 Profile Send private message  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 10 posts ] 

All times are UTC - 6 hours [ DST ]


Who is online

Users browsing this forum: Bing [Bot] and 3 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group