intfiction.org

The Interactive Fiction Community Forum
It is currently Mon Dec 17, 2018 8:30 am

All times are UTC - 6 hours [ DST ]




Post new topic Reply to topic  [ 10 posts ] 
Author Message
PostPosted: Sun May 04, 2014 8:01 pm 
Offline

Joined: Tue Mar 18, 2008 9:04 am
Posts: 1133
This topic is for discussions related to Measured Liquid by Emily Short


Top
 Profile Send private message  
Reply with quote  
PostPosted: Wed Dec 30, 2015 9:48 am 
Offline

Joined: Wed Dec 30, 2015 9:38 am
Posts: 2
Hello! Thanks for writing this extension. It works great in release 6L38, which is currently the second-to-latest release, but I noticed that it doesn't compile on what is currently the latest release, 6M62 (which seems to be available only on OS X, for some reason). It seems to fail with the following problem:

Quote:
Problem. You wrote 'let L be the value produced by the liquid-mixing rules for the amount poured' , but although 'value' is the name of a kind, it isn't a definite kind and is instead a general description which might apply to many different kinds. (For example, 'let R be a relation' is vague because it doesn't make clear what R will relate - 'let R be a relation of numbers' would be fine.)
I was trying to match one of these phrases:

1. (value - name of kind) produced by (liquid-mixing rules - values based rule producing values) for (amount poured - value)
2. (value - name of kind) produced by (liquid-mixing rules for the amount poured - rule producing values)
3. (value - name of kind) produced by (liquid-mixing rules for the amount poured - nothing based rule producing values)
I recognised:

value = a description of values
liquid-mixing rules = a volumes based rulebook producing liquids
amount poured = a non-temporary variable, holding a volume
But I didn't recognise 'liquid-mixing rules for the amount poured'.


The following problem was also output:

Quote:
Problem. In the sentence 'now the resulting liquid is L' , I was expecting to read a condition, but instead found some text that I couldn't understand - 'the resulting liquid is L'.


Top
 Profile Send private message  
Reply with quote  
PostPosted: Fri Jan 01, 2016 9:18 am 
Offline

Joined: Wed Dec 30, 2015 9:38 am
Posts: 2
Update: I think I found a fix for this! See this link for a full diff:

https://github.com/toolness/pancakes/is ... -168309181


Top
 Profile Send private message  
Reply with quote  
PostPosted: Sat Jul 09, 2016 9:55 am 
Offline

Joined: Sat Jul 09, 2016 9:53 am
Posts: 1
Your fix worked perfectly for me. Thanks!


Top
 Profile Send private message  
Reply with quote  
PostPosted: Sun Jul 24, 2016 10:12 pm 
Offline

Joined: Sun Jul 24, 2016 9:55 pm
Posts: 3
Hi folks

I'm struggling to include V4 of Measured Liquid in 6M62.

I get the bug:
Quote:
'Table of Liquids' , column 3 (flavor), the entry '"Refreshing!"' (row 2) is a genuine, non-blank entry: it's a specific value. That's fine, of course - the whole idea of a table is to contain values - but this is a column which already contains a name of a kind: 'some text'.


Here's the problem code:
Quote:
Table of Liquids
liquid potable flavor description
nonliquid false some text some text
water true "Refreshing!" --


I've tried fixing this myself, but I'm a newbie getting back into Inform, and just end up completely crashing the thing with an error 11.

Can anyone lend a hand?
Cheers


Top
 Profile Send private message  
Reply with quote  
PostPosted: Sun Jul 31, 2016 8:14 pm 
Offline

Joined: Sat Dec 26, 2015 7:34 pm
Posts: 517
I think the problem is that the flavor column has two different types of non-blank values in it: some text, which is the name of a kind, and "Refreshing!", which is a text. All of the values in a column (other than the header which gives the name/type of the column) need to be of the same type or blank (--).

The current version of Measured Liquids is v6, and the code in question looks like this:
Code:
Table of Liquids
liquid   potable   flavor   description (text)
nonliquid   false   --   --
water   true   "Refreshing!"   --

So, my suggestion would be to upgrade from v4 to v6. You can do this by choosing the extensions panel in the IDE, clicking on the Public Library tab at the top right, following the menus to the desired extension (§9. Physics -> §9.1. Liquids -> Measured Liquid), and clicking on the install/update button next to its name.

_________________
Vince Laviano


Top
 Profile Send private message  
Reply with quote  
PostPosted: Sun Jul 31, 2016 9:34 pm 
Offline

Joined: Sun Jul 24, 2016 9:55 pm
Posts: 3
Thanks Vince! Rookie mistake - I picked up the extension via Google and could only see the V4.


Top
 Profile Send private message  
Reply with quote  
PostPosted: Mon Jan 30, 2017 12:14 am 
Offline

Joined: Fri May 31, 2013 3:54 pm
Posts: 110
Found a bug in v6. Per the documentation, if cranberry juice + vodka = crantini, mixing more vodka into a crantini should just keep it as "crantini"; but in fact the extension changes it to pure "vodka". The problem is here:
Code:
A liquid-mixing rule (this is the keep the same recipe as before rule):
   [If we add more of an existing component to the mix, there is no change]
   repeat through the Table of Liquid Mixtures:
      if the liquid of the second noun is the result entry:
         let L be the mix-list entry;
         repeat with item running through L:
            if the liquid of the noun is the item:
               rule succeeds with result the liquid of the noun.
The last line should be "rule succeeds with result the liquid of the second noun".


Top
 Profile Send private message  
Reply with quote  
PostPosted: Sun Feb 12, 2017 10:04 am 
Offline

Joined: Tue Mar 09, 2010 2:34 pm
Posts: 5447
Location: Burlington, VT
I got in touch with Emily and she doesn't have time to work on this right now, but she said it would be fine for someone else to file updates to them. So prevetenet, if you want to make this change and file it (which I think means e-mailing it to Mark Musante) that would be great!


Top
 Profile Send private message  
Reply with quote  
PostPosted: Sun Feb 12, 2017 2:24 pm 
Offline

Joined: Fri May 31, 2013 3:54 pm
Posts: 110
Done; thanks!


Top
 Profile Send private message  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 10 posts ] 

All times are UTC - 6 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 4 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group